-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google-app-id to Vertex AI requests #14479
Conversation
f38393d
to
c9edcb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Paul! This LGTM to me at least. The FirebaseInfo
struct really cleans up a lot of call sites too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Andrew's comment. Nice refactor with FirebaseInfo
!
cbc98f8
to
b189b5c
Compare
Note, the header update part of this PR is disabled in #14493 pending the backend being ready to work with the change.
#no-changelog